Test for spamaway #7276

sssash18 · 2020-01-17T07:08:57Z

Fixes #4321 (<=== Add issue number here)
(part of issue)
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

PR is descriptively titled 📑 and links the original issue above 🔗
tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
code is in uniquely-named feature branch and has no merge conflicts 📁
screenshots/GIFs are attached 📎 in case of UI updation
ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

sync

codecov · 2020-01-17T07:16:56Z

Codecov Report

Merging #7276 into master will increase coverage by 20.34%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master   #7276       +/-   ##
==========================================
+ Coverage   61.25%   81.6%   +20.34%     
==========================================
  Files          97      97               
  Lines        5709    5599      -110     
==========================================
+ Hits         3497    4569     +1072     
+ Misses       2212    1030     -1182

Impacted Files	Coverage Δ
app/models/tag.rb	`97.46% <ø> (+0.46%)`	⬆️
app/models/node.rb	`90.92% <100%> (+2.98%)`	⬆️
app/controllers/application_controller.rb	`92.3% <100%> (+8.4%)`	⬆️
app/controllers/home_controller.rb	`98.38% <0%> (+1.61%)`	⬆️
app/models/user.rb	`91.01% <0%> (+1.95%)`	⬆️
app/models/image.rb	`82.5% <0%> (+2.5%)`	⬆️
app/models/comment.rb	`76.78% <0%> (+2.5%)`	⬆️
app/models/spamaway.rb	`94.87% <0%> (+2.56%)`	⬆️
app/models/tag_selection.rb	`96% <0%> (+4%)`	⬆️
... and 31 more

SidharthBansal

🎉 Great

SidharthBansal · 2020-01-17T10:05:02Z

@Uzay-G @VladimirMikulic what are your views?
Can we merge this?

VladimirMikulic · 2020-01-17T15:22:30Z

test/integration/signup_flow_test.rb

@@ -80,6 +80,25 @@ def setup
    assert response.body.include? 'errors prohibited this user from being saved'
    assert response.body.include? 'Email should look like an email address.'
  end
+  test 'spamaway text area not blank error message'


There should be an empty line between the tests.

test 'something' do # Logic end

VladimirMikulic

Also, please resolve the issue with Travis.

VladimirMikulic

Great job @sssash18 🚀

VladimirMikulic · 2020-01-17T15:28:41Z

@SidharthBansal we can merge this :)

sssash18 · 2020-01-17T15:29:35Z

Thank you @SidharthBansal @VladimirMikulic for your approval.

sssash18 · 2020-01-17T15:35:34Z

@VladimirMikulic @SidharthBansal Are their any more tests we need to add that I can help with?

VladimirMikulic

Whoops! Travis is broken, we can not merge this until Travis is fixed.

sssash18 · 2020-01-17T15:47:12Z

@VladimirMikulic Could you guide me about how to fix Travis here?

SidharthBansal · 2020-01-17T15:53:10Z

Ping any of us(@jywarren @SidharthBansal @VladimirMikulic @Uzay-G @cesswairimu ) if travis still fails

VladimirMikulic · 2020-01-17T15:55:11Z

Let me test it locally.

SidharthBansal · 2020-01-17T15:56:21Z

Sure

…

On Fri, Jan 17, 2020 at 9:25 PM Vladimir Mikulic ***@***.***> wrote: Let me test it locally. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#7276?email_source=notifications&email_token=AFAAEQ5GH7OHI36AG5DSXRDQ6HIGBA5CNFSM4KIDYIJ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJIDTXY#issuecomment-575683039>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFAAEQZCABIYI47M75CPE63Q6HIGBANCNFSM4KIDYIJQ> .

VladimirMikulic · 2020-01-17T16:12:46Z

Aha! I know where is the problem, should have noticed that earlier 😄
You are missing the do keyword, once you add it your test will pass.

VladimirMikulic · 2020-01-17T16:14:15Z

Check out my review comment.

sssash18 · 2020-01-17T16:16:27Z

Sorry all of you for such a silly mistake

VladimirMikulic · 2020-01-17T16:16:29Z

Fingers 🤞

SidharthBansal · 2020-01-17T16:17:16Z

No problem Suyash. If you will review my prs I can bet there will be 100 such errors.

…

On Fri, Jan 17, 2020 at 9:46 PM Suyash Choudhary ***@***.***> wrote: Sorry all of you for such a silly mistake — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#7276?email_source=notifications&email_token=AFAAEQ33657BPYSAUE7DT3TQ6HKVZA5CNFSM4KIDYIJ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJIF3RY#issuecomment-575692231>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFAAEQYVRHTNPCG7QA5ZE53Q6HKVZANCNFSM4KIDYIJQ> .

VladimirMikulic · 2020-01-17T16:17:31Z

@sssash18 don't apologise! It happens to everyone.

SidharthBansal · 2020-01-17T16:17:41Z

We all are learning. Its important to continue learning despite of failures and successes too On Fri, Jan 17, 2020 at 9:47 PM Sidharth Bansal < bansal.sidharthcode@gmail.com> wrote:

…

No problem Suyash. If you will review my prs I can bet there will be 100 such errors. On Fri, Jan 17, 2020 at 9:46 PM Suyash Choudhary ***@***.***> wrote: > Sorry all of you for such a silly mistake > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#7276?email_source=notifications&email_token=AFAAEQ33657BPYSAUE7DT3TQ6HKVZA5CNFSM4KIDYIJ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJIF3RY#issuecomment-575692231>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AFAAEQYVRHTNPCG7QA5ZE53Q6HKVZANCNFSM4KIDYIJQ> > . >

sssash18 · 2020-01-17T16:51:40Z

@SidharthBansal I think now it's fine.

VladimirMikulic · 2020-01-17T16:52:02Z

Congratulations @sssash18 🚀 🚀 🚀

SidharthBansal

Awesome!
Just checking are you a GCI student?

cesswairimu · 2020-01-17T16:57:43Z

This is awesome 🎉 🎉

sssash18 · 2020-01-17T17:30:39Z

Awesome!
Just checking are you a GCI student?

No @SidharthBansal

* Added 'spamaway_textarea blank error' test * Added empty line between the test * Added 'do'

sssash18 added 2 commits January 17, 2020 12:34

Merge pull request #1 from publiclab/master

429a545

sync

Added 'spamaway_textarea blank error' test

bdc8754

sssash18 requested a review from SidharthBansal January 17, 2020 07:09

SidharthBansal added this to the Login/SignUp & OAuth milestone Jan 17, 2020

SidharthBansal approved these changes Jan 17, 2020

View reviewed changes

VladimirMikulic reviewed Jan 17, 2020

View reviewed changes

VladimirMikulic requested changes Jan 17, 2020

View reviewed changes

Added empty line between the test

cf7f6de

VladimirMikulic approved these changes Jan 17, 2020

View reviewed changes

VladimirMikulic requested changes Jan 17, 2020

View reviewed changes

SidharthBansal closed this Jan 17, 2020

SidharthBansal reopened this Jan 17, 2020

Added 'do'

a2412e7

VladimirMikulic approved these changes Jan 17, 2020

View reviewed changes

SidharthBansal approved these changes Jan 17, 2020

View reviewed changes

SidharthBansal merged commit 9a5ffcd into publiclab:master Jan 17, 2020

vinitshahdeo pushed a commit to vinitshahdeo/plots2 that referenced this pull request Feb 1, 2020

Test for spamaway (publiclab#7276)

d15f45b

* Added 'spamaway_textarea blank error' test * Added empty line between the test * Added 'do'

NitinBhasneria pushed a commit to NitinBhasneria/plots2 that referenced this pull request Feb 5, 2020

Test for spamaway (publiclab#7276)

30fcb93

* Added 'spamaway_textarea blank error' test * Added empty line between the test * Added 'do'

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Test for spamaway #7276

Test for spamaway #7276

sssash18 commented Jan 17, 2020 •

edited

Loading

codecov bot commented Jan 17, 2020 •

edited

Loading

SidharthBansal left a comment

SidharthBansal commented Jan 17, 2020

VladimirMikulic Jan 17, 2020

VladimirMikulic Jan 17, 2020 •

edited

Loading

VladimirMikulic left a comment

VladimirMikulic left a comment

VladimirMikulic commented Jan 17, 2020

sssash18 commented Jan 17, 2020

sssash18 commented Jan 17, 2020

VladimirMikulic left a comment •

edited

Loading

sssash18 commented Jan 17, 2020

SidharthBansal commented Jan 17, 2020

VladimirMikulic commented Jan 17, 2020

SidharthBansal commented Jan 17, 2020 via email

VladimirMikulic commented Jan 17, 2020 •

edited

Loading

VladimirMikulic commented Jan 17, 2020

sssash18 commented Jan 17, 2020

VladimirMikulic commented Jan 17, 2020

SidharthBansal commented Jan 17, 2020 via email

VladimirMikulic commented Jan 17, 2020

SidharthBansal commented Jan 17, 2020 via email

sssash18 commented Jan 17, 2020

VladimirMikulic commented Jan 17, 2020

SidharthBansal left a comment

cesswairimu commented Jan 17, 2020

sssash18 commented Jan 17, 2020

Test for spamaway #7276

Test for spamaway #7276

Conversation

sssash18 commented Jan 17, 2020 • edited Loading

codecov bot commented Jan 17, 2020 • edited Loading

Codecov Report

SidharthBansal left a comment

Choose a reason for hiding this comment

SidharthBansal commented Jan 17, 2020

VladimirMikulic Jan 17, 2020

Choose a reason for hiding this comment

VladimirMikulic Jan 17, 2020 • edited Loading

Choose a reason for hiding this comment

VladimirMikulic left a comment

Choose a reason for hiding this comment

VladimirMikulic left a comment

Choose a reason for hiding this comment

VladimirMikulic commented Jan 17, 2020

sssash18 commented Jan 17, 2020

sssash18 commented Jan 17, 2020

VladimirMikulic left a comment • edited Loading

Choose a reason for hiding this comment

sssash18 commented Jan 17, 2020

SidharthBansal commented Jan 17, 2020

VladimirMikulic commented Jan 17, 2020

SidharthBansal commented Jan 17, 2020 via email

VladimirMikulic commented Jan 17, 2020 • edited Loading

VladimirMikulic commented Jan 17, 2020

sssash18 commented Jan 17, 2020

VladimirMikulic commented Jan 17, 2020

SidharthBansal commented Jan 17, 2020 via email

VladimirMikulic commented Jan 17, 2020

SidharthBansal commented Jan 17, 2020 via email

sssash18 commented Jan 17, 2020

VladimirMikulic commented Jan 17, 2020

SidharthBansal left a comment

Choose a reason for hiding this comment

cesswairimu commented Jan 17, 2020

sssash18 commented Jan 17, 2020

sssash18 commented Jan 17, 2020 •

edited

Loading

codecov bot commented Jan 17, 2020 •

edited

Loading

VladimirMikulic Jan 17, 2020 •

edited

Loading

VladimirMikulic left a comment •

edited

Loading

VladimirMikulic commented Jan 17, 2020 •

edited

Loading